WBCE CMS Forum

mrbaseman

Developer

Re: Output Filter Dashboard

it has found a few minor issues which I have committed with https://github.com/WBCE/WBCE_CMS/commit … 46ed2c3bea
there are indeed a couple of false positives in the list, and for quite a number of the warnings I must admit the tool is right, but I don't see an easy way to fix them.
Maybe you could have a look at the css warnings. I haven't done much in this area, and my css skills are not that good either. Most parts of the css code dates back almost 10 years now, and I have just kept what was there anyway.

PS: I haven't updated the version numbers because I believe all the changes don't have a real effect at all. For example the return values in the functions: if the setting is active, true is returned already. If the setting is inactive, the filter should not be called at all, so it should make no difference where the return statement is. But yes, it's cleaner code if a proper value is always returned.

Beitrag geändert von mrbaseman (22.10.2019 21:58:45)