WBCE CMS Forum

WBCE CMS – Way Better Content Editing.

Du bist nicht angemeldet.

#1 29.03.2018 11:56:18

losttrip
Mitglied

404 module notices

I have the "404" module installed from - https://addons.wbce.org/pages/addons.ph … em&item=86

I get the following notices in the backend (edit) Frontend:

Notice: Undefined index: storeip in /.../modules/mod404/functions.php on line 187

Notice: Undefined index: interval in /.../modules/mod404/functions.php on line 191

Notice: Undefined index: email in /.../modules/mod404/functions.php on line 195

Notice: Undefined index: subject in /.../modules/mod404/functions.php on line 196

Notice: Undefined index: interval in /.../modules/mod404/functions.php on line 239

I have to enter settings in the "Configuration" tab in order to remove the notices.  Maybe this is by design?  But if not, could/should these variables be set by default to avoid these notices?

Hope this helps.

Beitrag geändert von losttrip (29.03.2018 16:11:52)

Offline

#2 29.03.2018 12:08:07

florian
Administrator

Re: 404 module notices

I don't think the notices are by design.
Generally spoken, PHP notices are ment to give developers hints where to improve/fix their code. A notice is a less important flaw than a warning, and a warning is still not severe as an error (which usually breaks the PHP output).
You can switch off error reporting at the general options panel, then notices and warnings do not appear.
(Of course I know that this fixes only the symptomes but not the reasons.)


Code allein macht nicht glücklich. Jetzt spenden!

Offline

#3 29.03.2018 12:13:41

losttrip
Mitglied

Re: 404 module notices

I prefer not to switch off error reporting.  I am not bothered by the notices, and it gives me the opportunity to report my findings... to whomever might be interested.  I guess I could contact the developer directly, as I do not know if they are active on this forum.

Offline

#4 29.03.2018 12:20:53

florian
Administrator

Re: 404 module notices

Ruud looks in here from time to time too, but he will probably react faster if you post a comment on his module page.
https://dev4me.com/modules-snippets/opensource/404/


Code allein macht nicht glücklich. Jetzt spenden!

Offline

#5 29.03.2018 13:37:36

webbird
Administrator

Re: 404 module notices

Notices like these are very easy to fix. If you need a fix very fast, let me know. If not, better ask Ruud.


Ich habe eine Amazon-Wishlist. wink Oder spende an das Projekt.
Ich kann, wenn ich will, aber wer will, dass ich muss, kann mich mal

Offline

#6 29.03.2018 13:43:07

webbird
Administrator

Re: 404 module notices

Just downloaded that module and reviewed functions.php, seems as if there are some settings that may be missing in your installation. There should be a database table <Prefix>mod_404_cfg with at least 1 line. Please check this.

Beitrag geändert von webbird (29.03.2018 13:43:36)


Ich habe eine Amazon-Wishlist. wink Oder spende an das Projekt.
Ich kann, wenn ich will, aber wer will, dass ich muss, kann mich mal

Offline

#7 29.03.2018 13:59:02

webbird
Administrator

Re: 404 module notices

I have to enter settings in the "Configuration" tab in order to remove the notices.  Maybe this is by design?

Seems it is. Maybe we should add a note to our download page for the module.


Ich habe eine Amazon-Wishlist. wink Oder spende an das Projekt.
Ich kann, wenn ich will, aber wer will, dass ich muss, kann mich mal

Offline

#8 29.03.2018 15:46:15

losttrip
Mitglied

Re: 404 module notices

@webbird - I do not need a fix, but thank you for offering.  I do have "<Prefix>mod_404_cfg with at least 1 line", but I think that line is added only after entering settings in the Configuration... but I would have to check to see...

I messaged Ruud and my understanding is that this will be addressed in an upcoming version.

Offline

#9 29.03.2018 16:16:17

losttrip
Mitglied

Re: 404 module notices

I just checked.  I uninstalled the module and then re-installed 404 v1.1

Three tables are added:
wb_mod_404
wb_mod_404_cfg
wb_mod_404_errors
They are all empty.

I add the module to a section and I get the notices in the frontend (I mistakenly stated "backend" in my OP, sorry... I have corrected my post)

They don't go away until I enter settings in the Configuration dialogues. (or if I turn off error reporting, of course)

WBCE v1.3.1
PHP v5.6

Hope this helps.

Offline

#10 30.03.2018 09:37:52

dev4me
Developer

Re: 404 module notices

Released version 1.3 of the 404 module today.
Download and more info: https://dev4me.com/modules-snippets/opensource/404/

Fixes and additions:

- fix frontend errormessages when not yet configured
- fix correct order of rule processing
- oneforall pages detected and (optional) used for redirects
- bakery pages detected and (optional) used for redirects
- font change in email report
- added no-report.php with reporting filters for url and browser/bots
- added configuration: only report with referrer

Have fun with it.

Offline

#11 30.03.2018 13:32:01

losttrip
Mitglied

Re: 404 module notices

Thank you so much!

I do get the following error, after upgrading from v1.1, and choosing any time other than "every error" in "Send emails once per"

Parse error: syntax error, unexpected '<' in /.../modules/mod404/no-report.php on line 16

I removed the duplicate code, and the module is working beautifully!

I can't seem to replicate this on a clean install, but always on an upgrade from v1.1

Hope this helps.

Offline

#12 30.03.2018 13:46:24

dev4me
Developer

Re: 404 module notices

losttrip schrieb:
Parse error: syntax error, unexpected '<' in /.../modules/mod404/no-report.php on line 16

Ooops.. fixed in v1.3.1 available now.

Offline

#13 30.03.2018 13:58:15

florian
Administrator

Re: 404 module notices

thumb_up
Updated AOR entry.


Code allein macht nicht glücklich. Jetzt spenden!

Offline

#14 30.03.2018 14:58:11

losttrip
Mitglied

Re: 404 module notices

Great response.

I am just curious if this is the expected behaviour.  If I call the /404/ or /404.php page directly, I get an entry in the History (and a subsequent email report).

Wrong page requested: http://www.mysite.com/404/

Is this by design that you should not call the 404 page directly ?

Beitrag geändert von losttrip (30.03.2018 15:00:56)

Offline

#15 30.03.2018 15:25:31

dev4me
Developer

Re: 404 module notices

losttrip schrieb:

Is this by design that you should not call the 404 page directly ?

Yes,
On a page like this you typically would write a message saying something like
404 Page not found
and try to help the visitor to find what he needs (sitemap?).
It makes no sense to have a 404 page visible in your menu.

Offline

#16 30.03.2018 16:04:33

losttrip
Mitglied

Re: 404 module notices

I do have my 404 page set up, with a WYSIWYG message and direction... along with your 404 module in a section.  And the page is "hidden".

What I am asking is, if I happen to call that page directly (for instance from the backend "view" icon), then I am taken to the 404 page on the frontend as expected... but I also get an entry in your module for a wrong page request for hitting the /404/ page.  Is that intended/necessary?

Offline

#17 30.03.2018 16:17:12

dev4me
Developer

Re: 404 module notices

The module cannot decide if it was called intentionally or not.
When the module is loaded it will just do its thing.

If for some reason visitors go into your 404 page directly you would really like to know. It would mean your 404 page is listed in searchengines or on some other website (something you would not like).

Offline

#18 30.03.2018 19:13:36

losttrip
Mitglied

Re: 404 module notices

Makes total sense.  Thanks!  I was just curious.

Offline

Fußzeile des Forums

up